She is over the moon when men give her advice.

Literal

She [topic-は] men [by-に] is-advised [whenever-と] above this-not happily feels.

Three things stack here. 忠告される is the passive of 忠告する ('to advise'), with に marking the agent ('by men') — the standard Japanese passive structure. The conditional ~と here is the 'whenever / every time' use: a natural-consequence reading, where one event reliably follows another. この上なく is a vivid set adverbial, literally 'with nothing above this' — 'extremely / supremely / beyond compare' — sturdier and more emphatic than the everyday とても. The whole sentence describes a generic recurring response, not a one-off.